Skip to content

Add more regression tests around fetching/cloning from UNC paths#143

Closed
dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:test-unc-fetch
Closed

Add more regression tests around fetching/cloning from UNC paths#143
dscho wants to merge 1 commit into
gitgitgadget:masterfrom
dscho:test-unc-fetch

Conversation

@dscho

@dscho dscho commented Feb 25, 2019

Copy link
Copy Markdown
Member

On Windows, we want to make sure that we can fetch and clone from network drives. Let's add regression tests to make sure about that.

@dscho dscho added the ready to submit Has commits that have not been submitted yet label Feb 25, 2019
On Windows, it is quite common to work with network drives. The format
of the paths to network drives (or "network shares", or UNC paths) is:

	\\<server>\<share>\...

We already have a couple regression tests revolving around those types
of paths, but we missed cloning and fetching from UNC paths without
leading `file://` (and with backslashes instead of forward slashes).
This lil' patch closes that gap.

It gets a bit silly to add the commands to the name of the test script,
so let's just rename it while we're testing more UNC stuff.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho

dscho commented Feb 13, 2020

Copy link
Copy Markdown
Member Author

/submit

@gitgitgadget

gitgitgadget Bot commented Feb 13, 2020

Copy link
Copy Markdown

@dscho dscho removed the ready to submit Has commits that have not been submitted yet label Feb 14, 2020
@gitgitgadget

gitgitgadget Bot commented Feb 14, 2020

Copy link
Copy Markdown

This branch is now known as js/test-unc-fetch.

@gitgitgadget

gitgitgadget Bot commented Feb 14, 2020

Copy link
Copy Markdown

This patch series was integrated into pu via git@a445a7b.

@gitgitgadget gitgitgadget Bot added the pu label Feb 14, 2020
@gitgitgadget

gitgitgadget Bot commented Feb 14, 2020

Copy link
Copy Markdown

This patch series was integrated into pu via git@00546a4.

@gitgitgadget

gitgitgadget Bot commented Feb 17, 2020

Copy link
Copy Markdown

This patch series was integrated into pu via git@596f97d.

@gitgitgadget

gitgitgadget Bot commented Feb 17, 2020

Copy link
Copy Markdown

This patch series was integrated into pu via git@8ef4769.

@gitgitgadget

gitgitgadget Bot commented Feb 17, 2020

Copy link
Copy Markdown

This patch series was integrated into next via git@a4ca01e.

@gitgitgadget gitgitgadget Bot added the next label Feb 17, 2020
@gitgitgadget

gitgitgadget Bot commented Feb 17, 2020

Copy link
Copy Markdown

This patch series was integrated into pu via git@fc25a19.

@gitgitgadget

gitgitgadget Bot commented Feb 17, 2020

Copy link
Copy Markdown

This patch series was integrated into next via git@fc25a19.

@gitgitgadget

gitgitgadget Bot commented Feb 17, 2020

Copy link
Copy Markdown

This patch series was integrated into master via git@fc25a19.

@gitgitgadget gitgitgadget Bot added the master label Feb 17, 2020
@gitgitgadget gitgitgadget Bot closed this Feb 17, 2020
@gitgitgadget

gitgitgadget Bot commented Feb 17, 2020

Copy link
Copy Markdown

Closed via fc25a19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant