Improve checking when adding to PR cc: list#362
Merged
Conversation
dscho
reviewed
Nov 19, 2020
webstech
force-pushed
the
cc-with-space
branch
from
85115c7 to
15818c4
Compare
webstech
changed the title
dscho
reviewed
Nov 23, 2020
webstech
force-pushed
the
cc-with-space
branch
2 times, most recently
from
4114da5 to
9fbb322
Compare
dscho
reviewed
Nov 26, 2020
dscho
left a comment
dscho
left a comment
Member
There was a problem hiding this comment.
Sorry to make it so difficult, but I think this still needs to be tweaked a bit more.
webstech
force-pushed
the
cc-with-space
branch
from
9fbb322 to
696207c
Compare
dscho
reviewed
Dec 1, 2020
dscho
previously approved these changes
Dec 1, 2020
dscho
left a comment
dscho
left a comment
Member
There was a problem hiding this comment.
Looks pretty good! I like how sweet the unit test looks now (although I have to admit that I only skimmed it, trusting that it is correct).
The checking for existing entries in the cc: list will now: - allow a non-empty line (whitespace) before the footers - ignore case for both cc: entries and PR author email - support a body with only a footer - check only email and not names in cc: entries Tests were added to validate the new checks. Signed-off-by: Chris. Webster <chris@webstech.net>
Mock functions are now used for the tests. This removes the need to update the actual PR on GitHub, which is significantly faster. Signed-off-by: Chris. Webster <chris@webstech.net>
webstech
force-pushed
the
cc-with-space
branch
from
696207c to
9678577
Compare
dscho
approved these changes
Dec 2, 2020
Member
|
Thank you! |
Contributor
Author
|
Thank you for your patience. Should have been less painful for you. |
Member
|
Oh, but it wasn't painful at all! Thank you for taking such a lot of GitGitGadget maintenance off of my shoulders ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checking for existing entries in the cc: list will now:
The code assumes an empty line (may have whitespace) separates the body from the footers and no empty lines are in the footers.
Tests were added to validate the new checks.
This resolves a problem seen in 776 where users were copied multiple times and 783 where the PR author was copied.
Additionally this change will simplify GitHubGlue add CC testing:
Mock functions are now used for the tests. This removes the need to update the actual PR on GitHub, which is significantly faster.