Skip to content

Allow dot in Github slug - #204

Merged
alexcanessa merged 2 commits into
github-tools:masterfrom
Atry:patch-1
Dec 12, 2019
Merged

Allow dot in Github slug#204
alexcanessa merged 2 commits into
github-tools:masterfrom
Atry:patch-1

Conversation

@Atry

@Atry Atry commented Apr 11, 2019

Copy link
Copy Markdown
Contributor

Some repositories contains a dot character in the slug:

Some repository contains a dot character in the slug:
* https://github.com/ThoughtWorksInc/Binding.scala
@codecov-io

codecov-io commented Apr 11, 2019

Copy link
Copy Markdown

Codecov Report

Merging #204 into master will decrease coverage by 45.84%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #204       +/-   ##
===========================================
- Coverage   84.24%   38.39%   -45.85%     
===========================================
  Files           8        8               
  Lines         349      349               
===========================================
- Hits          294      134      -160     
- Misses         55      215      +160
Impacted Files Coverage Δ
lib/src/GitHubInfo.js 80.95% <100%> (-4.77%) ⬇️
lib/src/Gren.js 5.26% <0%> (-76.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8305f...fa77310. Read the comment docs.

@alexcanessa
alexcanessa merged commit cc0c851 into github-tools:master Dec 12, 2019
@alexcanessa

Copy link
Copy Markdown
Member

@all-contributors please add @Atry for code

@allcontributors

Copy link
Copy Markdown
Contributor

@alexcanessa

I've put up a pull request to add @Atry! 🎉

@Atry
Atry deleted the patch-1 branch February 3, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants