Fix browser markdown - #548
Merged
Merged
Conversation
clayreimann
approved these changes
Apr 10, 2019
Member
|
@j-rewerts I just looked and there's one markdown related test failing on this PR |
j-rewerts
force-pushed
the
fix-browser-markdown
branch
from
April 10, 2019 05:37
51ef4b7 to
dd6a3b1
Compare
Member
Author
|
@clayreimann Okay I think it should be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #451. Based on PR #505.
I also wrote a test to verify the conditions mentioned by the deleted user from #505 and @lvxianchao. We were returning null in the browser.