Address False Positives for Autosar A13-5-2 by jeongsoolee09 · Pull Request #186 · github/codeql-coding-standards

jeongsoolee09 · 2023-02-07T00:25:44Z

Description

Address false positives for Autosar A13-5-2.

Slapped isCompilerGenerated onto the where clause and now lambdas with empty capture is excluded: they were compiled internally to a set of nodes where one of them was for whatever reason a ConversionOperator.

Change request type

Release or process automation (GitHub workflows, internal scripts)
Internal documentation
External documentation
Query files (.ql, .qll, .qls or unit tests)
External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

No rules added
Queries have been added for the following rules:
- rule number here
Queries have been modified for the following rules:
- rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

Yes
No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Reviewer

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

lcartey

This also needs a change note, otherwise looks good!

…ng-standards into jeongsoolee09/a13-5-2

github-actions · 2023-02-23T23:55:09Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

github-actions · 2023-02-23T23:59:29Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

lcartey

One minor suggested format change, otherwise looks good to me!

github-actions · 2023-03-02T19:32:58Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-02T19:33:39Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-02T19:33:40Z

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-02T19:34:22Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
QUERY                : UserDefinedConversionOperatorsNotDefinedExplicit
COMPILE_ERROR_OUTPUT : 
RULE                 : A13-5-2
PACKAGE              : Operators
SUITE                : AUTOSAR
TEST_PASS            : True
COMPILE_PASS         : True

jsinglet · 2023-03-02T19:34:27Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
COMPILE_PASS         : True
RULE                 : A13-5-2
PACKAGE              : Operators
TEST_DIFFERENCE      : 
SUITE                : AUTOSAR
QUERY                : UserDefinedConversionOperatorsNotDefinedExplicit

jsinglet · 2023-03-02T19:34:38Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

Co-authored-by: Luke Cartey <5377966+lcartey@users.noreply.github.com>

github-actions · 2023-03-07T19:03:16Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-07T19:03:59Z

🤖 Beep Boop! gcc/c/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-07T19:04:01Z

🤖 Beep Boop! clang/c/x86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-07T19:04:41Z

🤖 Beep Boop! gcc/cpp/x86_64 Matrix Testing for this PR has been completed. See below for the results!


RULE                 : A13-5-2
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
SUITE                : AUTOSAR
PACKAGE              : Operators
QUERY                : UserDefinedConversionOperatorsNotDefinedExplicit
COMPILE_PASS         : True

jsinglet · 2023-03-07T19:04:45Z

🤖 Beep Boop! clang/cpp/x86_64 Matrix Testing for this PR has been completed. See below for the results!


QUERY                : UserDefinedConversionOperatorsNotDefinedExplicit
COMPILE_PASS         : True
TEST_PASS            : True
SUITE                : AUTOSAR
RULE                 : A13-5-2
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 
PACKAGE              : Operators

jsinglet · 2023-03-07T19:04:58Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

update

af0d0f5

jeongsoolee09 requested review from lcartey and rvermeulen February 7, 2023 00:25

jeongsoolee09 self-assigned this Feb 7, 2023

jeongsoolee09 marked this pull request as draft February 7, 2023 00:25

jeongsoolee09 added 2 commits February 7, 2023 13:56

update test.cpp

5a10397

format test.cpp

0ad2ab3

jeongsoolee09 marked this pull request as ready for review February 12, 2023 02:33

Merge branch 'main' into jeongsoolee09/a13-5-2

3e49b55

lcartey suggested changes Feb 22, 2023

View reviewed changes

Comment thread cpp/autosar/src/rules/A13-5-2/UserDefinedConversionOperatorsNotDefinedExplicit.ql Outdated

Comment thread cpp/autosar/src/rules/A13-5-2/UserDefinedConversionOperatorsNotDefinedExplicit.ql Outdated

jeongsoolee09 added 3 commits February 23, 2023 15:49

Clean up commented code

2fb5f48

Merge branch 'jeongsoolee09/a13-5-2' of github.com:github/codeql-codi…

b07058e

…ng-standards into jeongsoolee09/a13-5-2

Add missing change note

e9749e4

Merge branch 'main' into jeongsoolee09/a13-5-2

f609054

jeongsoolee09 enabled auto-merge February 23, 2023 23:59

lcartey approved these changes Mar 2, 2023

View reviewed changes

Comment thread change_notes/2022-02-23-a13-5-2-fix-reported-fp-for-a13-5-2.md Outdated

Merge branch 'main' into jeongsoolee09/a13-5-2

d981cef

auto-merge was automatically disabled March 7, 2023 15:58
Merge queue setting changed

Update change_notes/2022-02-23-a13-5-2-fix-reported-fp-for-a13-5-2.md

8f29669

Co-authored-by: Luke Cartey <5377966+lcartey@users.noreply.github.com>

lcartey added this pull request to the merge queue Mar 8, 2023

Merged via the queue into main with commit dcd22fd Mar 8, 2023

lcartey deleted the jeongsoolee09/a13-5-2 branch March 8, 2023 23:34

jeongsoolee09 mentioned this pull request Apr 7, 2023

A13-5-2: False positive on lambda with empty captures #178

Closed

Uh oh!

Conversation

jeongsoolee09 commented Feb 7, 2023

Description

Change request type

Rules with added or modified queries

Release change checklist

Query development review checklist

Author

Reviewer

Uh oh!

lcartey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 23, 2023

Uh oh!

github-actions Bot commented Feb 23, 2023

Uh oh!

lcartey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 2, 2023

Uh oh!

jsinglet commented Mar 2, 2023

Uh oh!

jsinglet commented Mar 2, 2023

Uh oh!

jsinglet commented Mar 2, 2023

Uh oh!

jsinglet commented Mar 2, 2023

Uh oh!

jsinglet commented Mar 2, 2023

Uh oh!

github-actions Bot commented Mar 7, 2023

Uh oh!

jsinglet commented Mar 7, 2023

Uh oh!

jsinglet commented Mar 7, 2023

Uh oh!

jsinglet commented Mar 7, 2023

Uh oh!

jsinglet commented Mar 7, 2023

Uh oh!

jsinglet commented Mar 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants