JS: Omit uninteresting nodes from path explanations#1036
Conversation
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
This looks like it will produce better paths.
We may want to refine the isHidden predicate later when we have more experience with inspecting paths.
Can we have some explicit tests for this feature?
The expected output of all existing path-problem tests need an update once we are satisfied with the implementation.
| query predicate nodes(PathNode nd) { any() } | ||
| query predicate nodes(PathNode nd) { | ||
| not nd.isHidden() or | ||
| nd instanceof SourcePathNode or |
There was a problem hiding this comment.
Edge case: the SourcePathNode character is independent of the path. So you may display a hidden SourcePathNode in the middle of your path. I suppose we can live with that.
There was a problem hiding this comment.
I'm fine with that.
|
Evaluation looks okay. After conferring with @xiemaisi I'll turn this into a 1.20 hotfix. |
asger-semmle
force-pushed
the
hide-implicit-ssa-defs
branch
from
d0f284a to
50a77ea
Compare
Writing a test for this feels like copy/pasting the implementation into a test to check they are the same. The updated output from every path-problem is not enough? |
2 participants
Hides nodes from the path explanation that aren't interesting. This includes:
+-based concatenation tree.Evaluation underway.