JavaScript: Consolidate more tests.#1038
Merged
Merged
Conversation
added 16 commits
March 5, 2019 08:04
Note that `CustomImport.ql` is still separate since it customises the standard library and would hence influennce other tests.
|
Sonuds plausible. |
Author
|
Yes, that's now done as part of consolidation. |
ghost
approved these changes
Mar 5, 2019
Author
|
Looks like this will save us another half hour or so of language test runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing in the vein of #1018 for all other folders that have at least ten individual tests in them (according to the data provided by @esben-semmle in #999).
In a few cases there were tests that couldn't be combined with the others because they introduced library customisations that would interfere with other tests. I manually split those out again.
The tool I used to do the conversion is here (internal link).