Python: Ignore dead entities from library trap files.#1042
Merged
taus-semmle merged 1 commit intoMar 6, 2019
Conversation
Contributor
Author
|
Not observable except by running the sanity check, so no change note required. |
markshannon
force-pushed
the
python-ignore-dead-objects
branch
from
142021c to
32dabce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trap files generated from the CPython builtin library contains information about builtin objects.
Some of these do not match up with the builtin objects from the interpreter.
Since these entities have no relations to others their presence is benign, so we can just ignore them
However, treating them as
Objects invalidates the sanity check. This PR fixes that.