Skip to content

Python: fix stack trace exposure query.#1043

Merged
taus-semmle merged 1 commit into
github:rc/1.20from
markshannon:python-fix-stack-trace-exposure
Mar 8, 2019
Merged

Python: fix stack trace exposure query.#1043
taus-semmle merged 1 commit into
github:rc/1.20from
markshannon:python-fix-stack-trace-exposure

Conversation

@markshannon

Copy link
Copy Markdown
Contributor

Avoid cross-talk between sources by more tightly specifying the type of the source.

Fixes a recent regression, so no change note needed.

We will want to prevent this in general for the next release by adding some sort of configuration, so the query would become something like

class InformationExposureConfiguration extends TaintTracking::Configuration {
    predicate isSource(TaintTracking::Source source) { source.getNode() instanceof ErrorInfoSource }
    predicate isSink(TaintTracking::Sink sink) { sink.getNode() instanceof ErrorInfoSink }
}
from InformationExposureConfiguration config, TaintedPathSource src, TaintedPathSink sink
where config.hasFlowPath(src, sink)
select sink.getNode(), src, sink, "$@ may be exposed to an external user", src.getSource(), "Error information"

However, that is probably too intrusive a change this close to the release.

@markshannon markshannon added this to the 1.20 milestone Mar 7, 2019
@taus-semmle taus-semmle merged commit 984fb3a into github:rc/1.20 Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants