C++: Fix join order in def-by-reference data flow#1070
Merged
Conversation
The performance was adequate on most projects but degenerated on https://github.com/Microsoft/Tocino.
Contributor
Author
|
This also affects nsnam/ns-3-dev-git. |
geoffw0
approved these changes
Mar 12, 2019
geoffw0
left a comment
geoffw0
left a comment
Contributor
There was a problem hiding this comment.
The change looks right to me. How confident are you of performance?
Contributor
Author
|
From a practical point of view, I've tested the change on the two problematic projects, and the performance issue went away. From a theoretical point of view, the |
Contributor
|
OK, I'll give it a quick spin myself (this is for the RC branch after all) and then merge. |
Contributor
|
Seems fine. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in #1000.
The performance was adequate on most projects but degenerated on https://github.com/Microsoft/Tocino.