C++: Add more tests that exercise the default taint barrier implementation#11428
Merged
Conversation
MathiasVP
approved these changes
Nov 25, 2022
MathiasVP
left a comment
MathiasVP
left a comment
Contributor
There was a problem hiding this comment.
LGTM! We could always argue whether or not that ideally should be a sanitizer, but from the current query's point of view, it should definitely be regarded as a sanitizer.
Contributor
Author
|
Definitely. Point is mostly for us to be able to notice regressions/changes on real code once we start changing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These demonstrate that the barrier on the sue-use dataflow feature branch is broken.