Skip to content

JavaScript: Show character code when reporting unexpected character.#1147

Merged
semmle-qlci merged 1 commit into
github:masterfrom
xiemaisi:js/show-char-code
Mar 21, 2019
Merged

JavaScript: Show character code when reporting unexpected character.#1147
semmle-qlci merged 1 commit into
github:masterfrom
xiemaisi:js/show-char-code

Conversation

@xiemaisi

Copy link
Copy Markdown

This should make it easier to understand syntax errors caused by zero-width characters such as this one.

@xiemaisi xiemaisi added the JS label Mar 21, 2019
@xiemaisi xiemaisi requested a review from a team as a code owner March 21, 2019 11:17

@asger-semmle asger-semmle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit 395089d into github:master Mar 21, 2019
@xiemaisi xiemaisi deleted the js/show-char-code branch April 2, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants