JavaScript: Add support for XML extraction.#1371
Merged
Merged
Conversation
Contributor
Ugh, yes that is an unfortunate inconsistency. Since Java presumably doesn't support |
asger-semmle
approved these changes
May 28, 2019
asger-semmle
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I can add the change to the TypeScript option in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This teaches the autobuilder about a new environment variable
LGTM_INDEX_XML_MODE, which can be eitherdisabled(the default) orall. The latter causes all.xmlfiles under$LGTM_SRCto be extracted. Additional XML extensions can be added via the existingLGTM_INDEX_FILETYPESvariable.The names of the XML modes were chosen for consistency with Java, though unfortunately that means they don't align well with the names of the TypeScript modes. We could allow
noneandfullas aliases fordisabledandallif desired (@asger-semmle, what do you think?).Like the C# and Java autobuilder, we perform the actual extraction by delegating to
odasa index --xml. This means that currently XML extraction does not respectinclude,excludeandfilters. It absolutely should, but it's a bit of a non-trivial change which will have to come later.No change note in this PR, since end users aren't expected to set this environment variable directly. This feature will be documented when support for the corresponding
lgtm.ymlflag has been added.