Skip to content

Go: Avoid using getTarget() as it may not exist #13785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owen-mc merged 4 commits into from
Aug 2, 2023
Merged

Go: Avoid using getTarget() as it may not exist #13785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2b8d83
Avoid using getTarget() as it may not exist
owen-mc Jul 20, 2023
00d5cb7
Different approach to avoiding getTarget()
owen-mc Jul 28, 2023
0895853
Delete unused testing predicate
owen-mc Jul 28, 2023
dbc6868
Update go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
owen-mc Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions go/ql/lib/semmle/go/dataflow/internal/DataFlowDispatch.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,10 @@ predicate golangSpecificParamArgFilter(
// Interface methods calls may be passed strictly to that exact method's model receiver:
arg.getPosition() != -1
or
exists(Function callTarget | callTarget = call.getNode().(DataFlow::CallNode).getTarget() |
not isInterfaceMethod(callTarget)
or
callTarget = p.getCallable().asSummarizedCallable().asFunction()
)
p instanceof DataFlow::SummarizedParameterNode
or
not isInterfaceMethod(call.getNode()
.(DataFlow::CallNode)
.getACalleeWithoutVirtualDispatch()
.asFunction())
}
19 changes: 14 additions & 5 deletions go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,13 +489,9 @@ module Public {
* interface type.
*/
Callable getACalleeIncludingExternals() {
result.asFunction() = this.getTarget()
result = this.getACalleeWithoutVirtualDispatch()
or
exists(DataFlow::Node calleeSource | calleeSource = this.getACalleeSource() |
result.asFuncLit() = calleeSource.asExpr()
or
calleeSource = result.asFunction().getARead()
or
exists(Method declared, Method actual |
calleeSource = declared.getARead() and
actual.implements(declared) and
Expand All @@ -510,6 +506,19 @@ module Public {
*/
FuncDef getACallee() { result = this.getACalleeIncludingExternals().getFuncDef() }

/**
* Gets the definition of a possible target of this call, excluding targets reachable via virtual dispatch.
*/
Callable getACalleeWithoutVirtualDispatch() {
result.asFunction() = this.getTarget()
or
exists(DataFlow::Node calleeSource | calleeSource = this.getACalleeSource() |
result.asFuncLit() = calleeSource.asExpr()
or
calleeSource = result.asFunction().getARead()
)
}

/**
* Gets the name of the function, method or variable that is being called.
*
Expand Down