Skip to content

CPP: Make FunctionWithWrappers toCause work on builtins. #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbj merged 1 commit into from
Sep 4, 2018
Merged

CPP: Make FunctionWithWrappers toCause work on builtins. #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cpp/ql/src/semmle/code/cpp/security/FunctionWithWrappers.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,14 @@ import PrintfLike
private import TaintTracking

private
bindingset[index]

@jbj jbj Sep 4, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bindingset makes the function inline, which can make it harder to predict how it'll be optimised in future contexts. Do these unnamed parameters at least have a Parameter object? Then you should be able to add exists(func.getParameter(index)) after the or and remove the bindingset annotation.

@geoffw0 geoffw0 Sep 4, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that and I didn't get the same results (and the test fails). I believe getParameter had no results.

Because this predicate is private, any non-local performance effects due to inlining should be localized to within this library.

@jbj jbj Sep 4, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

string toCause(Function func, int index)
{
result = func.getQualifiedName() + "(" + func.getParameter(index).getName() + ")"
result = func.getQualifiedName() + "(" + func.getParameter(index).getName() + ")" or
(
not exists(func.getParameter(index).getName()) and
result = func.getQualifiedName() + "(arg " + index + ")"
)
}

/**
Expand Down