Skip to content

C++: Move Element.toString performance change note to 1.22 file#1401

Merged
geoffw0 merged 2 commits into
github:masterfrom
jbj:tostring-performance-1.22
Jun 5, 2019
Merged

C++: Move Element.toString performance change note to 1.22 file#1401
geoffw0 merged 2 commits into
github:masterfrom
jbj:tostring-performance-1.22

Conversation

@jbj

@jbj jbj commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

I merged #1366 even though its change note was in the wrong file because the alternative was to do another lengthy submodule update cycle. This PR moves the change note to the right place.

jbj added 2 commits June 4, 2019 20:45
This change didn't make into 1.21, so it doesn't belong in this file.

This reverts commit 8c09900.
@jbj jbj added the C++ label Jun 5, 2019

@geoffw0 geoffw0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffw0 geoffw0 merged commit 98eced9 into github:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants