Skip to content

Python: Fix up 'import failure' analysis query. #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taus-semmle merged 1 commit into from
Jun 5, 2019
Merged

Python: Fix up 'import failure' analysis query. #1405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions python/ql/src/analysis/ImportFailure.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,37 @@ predicate ok_to_fail(ImportExpr ie) {
os_specific_import(ie) != get_os()
}


class VersionTest extends @py_flow_node {

VersionTest() {
exists(string name |
name.matches("%version%") and
this.(CompareNode).getAChild+().pointsTo(Module::named("sys").attr(name))
)
}

string toString() {
result = "VersionTest"
}

}

/** A guard on the version of the Python interpreter */
class VersionGuard extends ConditionBlock {

VersionGuard() {
this.getLastNode() instanceof VersionTest
}

}

from ImportExpr ie
where not ie.refersTo(_) and
exists(Context c | c.appliesTo(ie.getAFlowNode())) and
not ok_to_fail(ie) and
not exists(VersionGuard guard |
if guard.isTrue() then
guard.controls(ie.getAFlowNode().getBasicBlock(), false)
else
guard.controls(ie.getAFlowNode().getBasicBlock(), true)
guard.controls(ie.getAFlowNode().getBasicBlock(), _)
)

select ie, "Unable to resolve import of '" + ie.getImportedModuleName() + "'."