C/C++ 1.22: finalize change notes#1811
Conversation
felicitymay
added
C++
Priority
|
LGTM. We need to be sure that the change notes reflect which (if any) of @jbj's recent changes to the dataflow / taint library we decide to ship with. |
Co-Authored-By: Nick Rolfe <nickrolfe@gmail.com>
The changes aren't finished in this release, but there widespread enough we should acknowledge them. Originally github#1812.
|
I've added my change here. I was expecting it to 'suggest' the change but it's simply added it as a commit, so @felicity-semmle please review that commit and reword as necessary. |
|
Thanks @geoffw0. That looks fine unless we want to make it more prominent. I know that you've all put a lot of effort into improving the library documentation. |
|
That's true, but given that (1) the work is not complete in this release and (2) users don't need to know about it or do take actions to benefit, I don't think it needs to be especially prominent. |
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
Changes LGTM, but these change notes may not be final. It depends on whether we decide to revert field flow.
4 participants
The first commit removes unwanted boilerplate text and sorts the table alphabetically.
The second commit makes some minor text changes.
@Semmle/cpp - I find line 24 difficult to understand and would appreciate a suggestion or direct edit to that line. It looks as if it would be improved with either punctuation, or backticks to indicate code elements.