JS: Change notes for jump-to-def and documentation improvements#1825
Merged
Conversation
asger-semmle
commented
Aug 26, 2019
asger-semmle
commented
Contributor
- Mentions jump-to-def improvements in the general section.
- Mentioned documentation improvements in the "QL libraries" section as that's mainly of interest to QL writers.
felicitymay
reviewed
Aug 26, 2019
felicitymay
left a comment
felicitymay
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes. One typo, but otherwise LGTM. I'll leave @xiemaisi to review and merge.
Co-Authored-By: Felicity Chapman <felicity@semmle.com>
xiemaisi
approved these changes
Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.