C++: Change name of UncheckedReturnValueForTimeFunctions.ql#1838
Merged
Conversation
The previous name was identical to the name of `Adding365DaysPerYear.ql`. It may have been a copy-paste error.
geoffw0
reviewed
Aug 28, 2019
| /** | ||
| * @name Year field changed using an arithmetic operation is used on an unchecked time conversion function | ||
| * @name Unchecked return value for time conversion function | ||
| * @description A year field changed using an arithmetic operation is used on a time conversion function, but the return value of the function is not checked for success or failure |
Contributor
There was a problem hiding this comment.
The @descriptions of the two queries still match, and to be honest, I find the names and descriptions of these queries quite confusing (compared to the violation messages and qhelp, which make things much clearer).
Contributor
Author
There was a problem hiding this comment.
I've pushed a commit to try and improve these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous name was identical to the name of
Adding365DaysPerYear.ql. It may have been a copy-paste error.