Merge rc/1.18 into next.#185
Merged
Merged
Conversation
The overrides of `Instruction.getOperandMemoryAccess` did not relate `this` to any of its other parameters, which made it attempt to compute the Cartesian product of `Instruction` and `TPhiOperand`. This happened only during computation of aliased SSA. Perhaps the optimizer was able to eliminate the CP for the non-aliased SSA computation. With this change, I'm able to compute aliased SSA for medium-sized snapshots.
Follow a naming structure similar to the data flow library: - `ControlFlowNode` -> `ControlFlow::Node`. - `CallableEntryNode` -> `ControlFlow::Nodes::EntryNode`. - `CallableExitNode` -> `ControlFlow::Nodes::ExitNode`. - `ControlFlowEdgeType` -> `ControlFlow::SuccessorType`. - `ControlFlowEdgeSuccessor` -> `ControlFlow::SuccessorTypes::NormalSuccessor`. - `ControlFlowEdgeConditional -> ControlFlow::SuccessorTypes::ConditionalSuccessor`. - `ControlFlowEdgeBoolean` -> `ControlFlow::SuccessorTypes::BooleanSuccessor`. - `ControlFlowEdgeNullness` -> `ControlFlow::SuccessorTypes::NullnessSuccessor`. - `ControlFlowEdgeMatching` -> `ControlFlow::SuccessorTypes::MatchingSuccessor`. - `ControlFlowEdgeEmptiness` -> `ControlFlow::SuccessorTypes::EmptinessSuccessor`. - `ControlFlowEdgeReturn` -> `ControlFlow::SuccessorTypes::ReturnSuccessor`. - `ControlFlowEdgeBreak` -> `ControlFlow::SuccessorTypes::BreakSuccessor`. - `ControlFlowEdgeContinue` -> `ControlFlow::SuccessorTypes::ContinueSuccessor`. - `ControlFlowEdgeGotoLabel` -> `ControlFlow::SuccessorTypes::GotoLabelSuccessor`. - `ControlFlowEdgeGotoCase` -> `ControlFlow::SuccessorTypes::GotoCaseSuccessor`. - `ControlFlowEdgeGotoDefault` -> `ControlFlow::SuccessorTypes::GotoDefaultSuccessor`. - `ControlFlowEdgeException` -> `ControlFlow::SuccessorTypes::ExceptionSuccessor`
C#: Rename and restructure control flow graph entities
- While statements - Object initializers
…andled. Move `getCondition` to `CaseStmt`. Implement the CFG and tests.
…change-notes LGTM 1.18: finalize change notes for C/C++
Approved by yh-semmle
C#: Fix CFG for unknown expressions
…-notes LGTM 1.18: finalize change notes for C#
JavaScript: fix CFG for EnhancedForStmt
Approved by asger-semmle
LGTM 1.18: finalize the JavaScript change notes
adityasharad
added
depends on internal PR
Contributor
|
Why not against |
Collaborator
Author
|
I created this to aid an internal mergeback from 1.18 to |
hvitved
approved these changes
Sep 12, 2018
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Improve performance of `internal/Module.qll`
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Jan 17, 2022
…d-tests Add tests for generic methods
MathiasVP
pushed a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
PS: Fixup SSA after GitHub's 2.21.0 changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No conflicts.