Skip to content

C#: Remove the 'security' tag from some queries#274

Merged
hvitved merged 1 commit into
github:masterfrom
lcartey:csharp/remove-security-tags
Apr 3, 2019
Merged

C#: Remove the 'security' tag from some queries#274
hvitved merged 1 commit into
github:masterfrom
lcartey:csharp/remove-security-tags

Conversation

@lcartey

@lcartey lcartey commented Oct 3, 2018

Copy link
Copy Markdown
Contributor

These three queries specify the security tag, but are usually not security critical findings. Removing the security tag will help rank these results appropriately in LGTM.

These queries are only tenuously security queries, and marking them as
security queries can cause them to have greater prominence than is
merited by the results that they report.
@lcartey lcartey added the C# label Oct 3, 2018
@lcartey lcartey requested a review from hvitved October 3, 2018 10:59
@lcartey lcartey requested a review from a team as a code owner October 3, 2018 10:59
@calumgrant

Copy link
Copy Markdown
Contributor

What's the status of this?

@hvitved hvitved merged commit f5d52d0 into github:master Apr 3, 2019
aibaars pushed a commit that referenced this pull request Oct 14, 2021
CFG: Model calls that may raise an exception
smowton added a commit to smowton/codeql that referenced this pull request Apr 16, 2022
…nch-found

Extract no-when-branch-found calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants