C++: Use IR for security.TaintTracking and GVN#2851
Merged
Conversation
Without this, the test will compare the IR to itself after we enable it.
This is for the tests in the ql repo. There are also changed tests in the internal repo.
jbj
added
the
depends on internal PR
The language tests were failing because they don't tolerate mentioning a deprecated class anywhere.
rdmarsh2
approved these changes
Feb 18, 2020
rdmarsh2
left a comment
rdmarsh2
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Failing tests are fixed by internal PR 36239.
This was referenced Feb 19, 2020
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 2, 2025
…ut the IR into production in github#2851.
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 3, 2025
…ut the IR into production in github#2851.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only merge this if https://git.semmle.com/Semmle/code/pull/36239 can be merged immediately after.
This is the big one! When this is merged, the IR will be in production.