1.24 release: finalize change notes for JavaScript#3286
Merged
felicitymay merged 3 commits intoApr 20, 2020
Conversation
esbena
reviewed
Apr 17, 2020
esbena
left a comment
esbena
left a comment
Contributor
There was a problem hiding this comment.
LGTM. With one minor style question.
Co-Authored-By: Esben Sparre Andreasen <esbena@github.com>
esbena
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to finalize the analysis change notes ready for inclusion with LGTM Enterprise.
I've made few changes. This set of change notes was already in great order. Thanks 🙇♀️
The first commit reorders rows in one table and the list of frameworks.
The second commit makes a few text changes, mostly to reinforce the reduction in the number of results.
Please check that I haven't introduced any errors: @Semmle/js