1.24: Move python change notes into rc/1.24 branch#3321
Merged
tausbn merged 3 commits intoApr 22, 2020
Conversation
(cherry picked from commit e97d88c)
Co-Authored-By: Felicity Chapman <felicitymay@github.com> (cherry picked from commit 44b570f)
We don't hyphenate "QL-library" and there were a few typos. Feel free to further revise this if I've changed the meaning too much. As discussed separately, I was unable to raise this as a PR in GitHub.com and had to resort to a direct commit. (cherry picked from commit e294681)
tausbn
approved these changes
Apr 22, 2020
tausbn
left a comment
tausbn
left a comment
Contributor
There was a problem hiding this comment.
I think this is fine. If the mergeback ends up conflicting, I’ll take care of it.
(I feel rather silly for not realising I had the wrong branch. 😞)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the point of view of history, #3315 should have been targeted against the
rc/1.24branch. I entirely overlooked this when reviewing it.I've cherry-picked those commit directly onto a new branch from
rc/1.24.@tausbn - not sure if this is the best way to resolve this, or whether it's not worth worrying about.