Python: Fix (upcoming) deprecation compiler-warnings#3551
Merged
Conversation
In a near-future release overriding a deprecated predicate without making as deprecated would give a compiler warning. Not fixing the XML one. [I can see that this shouldn't be reported anymore](github#3520 (comment)), and it's not safe to remove since it was only marked as deprecated in e6425bb.
Contributor
|
Thank you for going ahead with this proactively, much appreciated! |
tausbn
previously approved these changes
May 25, 2020
tausbn
left a comment
tausbn
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I'll just double-check the compilation log on Jenkins before merging this (once the tests have passed).
Contributor
|
|
Member
Author
Since the compiler changes have not been merged yet (as far as I understand), you won't be able to see any warnings in the compilation log either 😉 |
tausbn
approved these changes
May 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a near-future release overriding a deprecated predicate without making as deprecated would give a compiler warning.
Not fixing the XML one. I can see that this shouldn't be reported anymore, and it's not safe to remove since it was only marked as deprecated in e6425bb.
/cc @ginsbach