Skip to content

C++: Remove duplication-tests#4715

Merged
criemen merged 1 commit into
github:mainfrom
MathiasVP:remove-failing-duplicate-tests
Nov 24, 2020
Merged

C++: Remove duplication-tests#4715
criemen merged 1 commit into
github:mainfrom
MathiasVP:remove-failing-duplicate-tests

Conversation

@MathiasVP

Copy link
Copy Markdown
Contributor

I noticed that they broke when doing CPP Language tests for #4702. It might have something to do with https://github.com/github/semmle-code/pull/38251, but I'm not exactly sure.

@MathiasVP MathiasVP added the C++ label Nov 24, 2020
@MathiasVP MathiasVP requested a review from a team as a code owner November 24, 2020 09:13
@criemen

criemen commented Nov 24, 2020

Copy link
Copy Markdown
Collaborator

Note that the CPP distro tests used to test the duplicate code feature, too, until https://github.com/github/codeql-tracer/issues/25.
There I was informed that the duplicate-code feature has not been ported to codeql, with the exception of codeql test run, and that there are no plans for this feature.

@MathiasVP

Copy link
Copy Markdown
Contributor Author

There I was informed that the duplicate-code feature has not been ported to codeql, with the exception of codeql test run, and that there are no plans for this feature.

Thanks for the link! All the more reason to delete the tests, I guess.

@criemen criemen merged commit 14a03e2 into github:main Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants