Python: dataflow, unify iterated unpacking#5047
Merged
tausbn merged 7 commits intoFeb 4, 2021
Merged
Conversation
read-step. Add a version targetting sequence nodes.
yoff
force-pushed
the
python-dataflow-unpacking-unifying-experiments
branch
from
9d7019e to
182d435
Compare
tausbn
reviewed
Feb 1, 2021
tausbn
requested changes
Feb 1, 2021
tausbn
left a comment
tausbn
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable. Just a few comments and questions.
…ate.qll Co-authored-by: Taus <tausbn@github.com>
RasmusWL
reviewed
Feb 2, 2021
RasmusWL
left a comment
RasmusWL
left a comment
Member
There was a problem hiding this comment.
Overall looks good to me, although I'm surprised we're not able to handle more comprehensions
| def test_unpacking_comprehension(): | ||
| x = [a for (a, b) in [(SOURCE, NONSOURCE)]] | ||
| SINK(x[0]) # Flow missing | ||
| SINK(x[0]) #$ MISSING:flow="SOURCE, l:-1 -> x[0]" |
Member
There was a problem hiding this comment.
I'm surprised we're not able to handle this one now. can you explain why? 😕
Contributor
Author
There was a problem hiding this comment.
Thanks! I had missed this bit..
…ate.qll Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
tausbn
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
forread-step and makes the comprehension read-step obsolete.It also adds a
forread-step targetting sequences.