Python path queries#516
Merged
Merged
Conversation
felicitymay
reviewed
Nov 21, 2018
| * @kind problem | ||
| * @problem.severity error | ||
| * @precision medium | ||
| * @precision high |
Contributor
There was a problem hiding this comment.
This is going to change the behaviour of this query on LGTM. Please add a change note.
felicitymay
reviewed
Nov 21, 2018
| * @name Uncontrolled data used in path expression | ||
| * @description Accessing paths influenced by users can allow an attacker to access unexpected resources. | ||
| * @kind problem | ||
| * @kind path-problem |
Contributor
There was a problem hiding this comment.
We should probably have a change note about the conversion of some queries to path queries.
markshannon
force-pushed
the
python-path-queries
branch
from
4bf5c7c to
c01db23
Compare
taus-semmle
previously approved these changes
Nov 23, 2018
taus-semmle
left a comment
taus-semmle
left a comment
Contributor
There was a problem hiding this comment.
Generally LGTM. I have a few comments/questions, but nothing that must be addressed before merging.
| | command_injection.py:12:15:12:27 | shell command | command_injection.py:10:13:10:24 | Taint {externally controlled string} at command_injection.py:10 | command_injection.py:12:15:12:27 | Taint externally controlled string at command_injection.py:12 | This command depends on $@. | command_injection.py:10:13:10:24 | flask.request.args | a user-provided value | | ||
| | command_injection.py:19:22:19:34 | shell command | command_injection.py:17:13:17:24 | Taint {externally controlled string} at command_injection.py:17 | command_injection.py:19:22:19:34 | Taint [externally controlled string] at command_injection.py:19 | This command depends on $@. | command_injection.py:17:13:17:24 | flask.request.args | a user-provided value | | ||
| | command_injection.py:25:22:25:36 | OS command first argument | command_injection.py:24:11:24:22 | Taint {externally controlled string} at command_injection.py:24 | command_injection.py:25:22:25:36 | Taint [externally controlled string] at command_injection.py:25 | This command depends on $@. | command_injection.py:24:11:24:22 | flask.request.args | a user-provided value | | ||
| | command_injection.py:25:22:25:36 | OS command first argument | command_injection.py:24:11:24:22 | Taint {externally controlled string} at command_injection.py:24 | command_injection.py:25:22:25:36 | Taint sequence[externally controlled string][0] at command_injection.py:25 | This command depends on $@. | command_injection.py:24:11:24:22 | flask.request.args | a user-provided value | |
Contributor
There was a problem hiding this comment.
I wonder why this final result was duplicated.
Contributor
There was a problem hiding this comment.
Ah, I see the difference. One has [0] appended to the taint.
|
|
||
| select sink, "This path depends on $@.", src, "a user-provided value" | ||
| from TaintedNode srcnode, TaintedNode sinknode, TaintSource src, TaintSink sink | ||
| where src.flowsToSink(sink) and srcnode.getNode() = src and sinknode.getNode() = sink |
Contributor
There was a problem hiding this comment.
I feel like the srcnode.getNode() = src and sinknode.getNode() = sink construction is a bit clunky. Could we make this into a method (.getSource()) on TaintedNodes, etc. and then simply use srcnode.getSource() in the select statement?
Contributor
Author
There was a problem hiding this comment.
That makes sense. I've changed the general form from
from TaintedNode srcnode, TaintedNode sinknode, TaintSource src, TaintSink sink
where src.flowsToSink(sink) and srcnode.getNode() = src and sinknode.getNode() = sink
select sink, srcnode, sinknode, ..., src, ...
to
from TaintedPathSource src, TaintedPathSink sink
where src.flowsTo(sink)
select sink.getSink(), src, sink,..., src.getSource(), ...
…e queries and tests accordingly.
markshannon
force-pushed
the
python-path-queries
branch
from
6ca032d to
61bd868
Compare
taus-semmle
approved these changes
Nov 23, 2018
aschackmull
reviewed
Nov 23, 2018
| child = first_child(parent) or | ||
| exists(TaintedNode prev | | ||
| parents(prev, parent) and | ||
| child = next_sibling(child) |
Contributor
There was a problem hiding this comment.
Post-merge drive-by comment: This looks wrong.
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
…review-workflow Actions: Remove docs-review workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.