Skip to content

C++: Deprecate queries using VCS.qll#518

Merged
pavgust merged 1 commit into
github:masterfrom
jbj:vcs-deprecate-queries
Nov 22, 2018
Merged

C++: Deprecate queries using VCS.qll#518
pavgust merged 1 commit into
github:masterfrom
jbj:vcs-deprecate-queries

Conversation

@jbj

@jbj jbj commented Nov 22, 2018

Copy link
Copy Markdown
Contributor

These are all the files I could find with git grep 'import.*VCS'.

One query imported VCS.qll for no reason, so I removed the import instead of deprecating the query.

One query imported VCS.qll for no reason, so I removed the import
instead of deprecating the query.
@jbj jbj added the C++ label Nov 22, 2018
@jbj jbj added this to the 1.19 milestone Nov 22, 2018
@jbj jbj requested a review from a team as a code owner November 22, 2018 07:24
@geoffw0

geoffw0 commented Nov 22, 2018

Copy link
Copy Markdown
Contributor

Do we want a comment explaining the deprecation for queries, like we do with classes and predicates?

What's the history of VCS.qll? I assume it's not relevant on LGTM, is it currently possible to use it in QL for Eclipse? Has it changed recently?

@sj

sj commented Nov 22, 2018

Copy link
Copy Markdown
Contributor

Thanks @jbj!

@geoffw0: see https://jira.semmle.com/browse/ODASA-7486 for more detailed discussion. It's not used on LGTM.

@jbj

jbj commented Nov 22, 2018

Copy link
Copy Markdown
Contributor Author

Sorry, I should have linked to the Jira issue from here.

@pavgust pavgust left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pavgust pavgust merged commit b9a3a71 into github:master Nov 22, 2018
cklin pushed a commit that referenced this pull request May 23, 2022
…nder-codeql

Tolerate empty-string CODEQL_PLATFORM, and add smoke tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants