TS: only transfer offsets as part of the AST#529
Merged
Conversation
xiemaisi
approved these changes
Nov 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serialized TypeScript AST contains the start/end positions of all AST nodes. Each position was encoded as an object of form
{line, character, $offset}. Having two of those per AST node accounted for quite a bit of the serialization overhead.We now only send the offset as a number, and compute the corresponding line/character in the Java side.
Some timings:
The angular runs were a bit flaky, but the others are consistently faster.