TS: declassify files with unrecognized shebang line#551
Merged
Conversation
xiemaisi
reviewed
Nov 27, 2018
xiemaisi
left a comment
xiemaisi
left a comment
There was a problem hiding this comment.
LGTM. @esben-semmle, how do you feel about this going into the rc?
|
LGTM. This seems very safe for the RC. |
xiemaisi
approved these changes
Nov 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ODASA-7490.
JavaScript files are unaffected for now, but .ts and .tsx files will not be extracted if it starts with an unrecognized shebang.
Targeting rc/1.19 mainly to avoid forking the extractor right out of the gate, but can retarget to next if anyone thinks it's too controversial.