JS: fix unused 'React' variable FP#557
Merged
Merged
Conversation
ghost
self-requested a review
as a 
ghost
added
WIP
Author
|
The simplification is safe, both in terms of results and performance. The only additional kind of FP that is eliminated is |
xiemaisi
approved these changes
Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates
var React = require('react')as ajs/unused-local-variableFP in the presence of JSX elements.The first commit is a refactoring to make the fix simpler.
This does not whitelist the
var { React } = require("probably-react");, it seems to be quite messy to support that potential corner case (or am I missing an obvious solution?).Performance is fine, and results are plenty.