Python: finalize change notes for 1.19#573
Merged
markshannon merged 2 commits intoNov 30, 2018
Merged
Conversation
markshannon
reviewed
Nov 29, 2018
|
|
||
| > Changes that affect alerts in many files or from many queries | ||
| > For example, changes to file classification | ||
| A new predicate `Stmt.getAnEntryNode()` has been added to make it easier to write reachability queries involving statements. |
Contributor
There was a problem hiding this comment.
This doesn't make as much sense out of context. This new predicate is necessary because of the changes to the CFG representation.
Contributor
Author
There was a problem hiding this comment.
Okay - that wasn't clear to me. I'll move it.
|
|
||
| A new predicate `Stmt.getAnEntryNode()` has been added to make it easier to write reachability queries involving statements. | ||
| | Old CFG node order | New CFG node order | | ||
| |--------------------|--------------------| |
Contributor
There was a problem hiding this comment.
I don't like the table form, as it suggest some relation between item of the same row, where there is none.
Contributor
Author
There was a problem hiding this comment.
Okay - I'll revise it.
Contributor
Author
|
@mark - does this work any better? |
Contributor
|
Yes, that's perfect |
markshannon
approved these changes
Nov 30, 2018
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Yet another SSRF query for Golang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@markshannon and @taus-semmle - I've made some changes to the analysis change notes for Python. They're mostly smallish changes for consistency and clarity. The only substantial change was to move the information about "Assert statement tests the truth value of a literal constant" (
py/assert-literal-constant) into the New queries table. As far as I can tell it was erroneously added to the wrong table.