Python/JS: Make most of the new library private

[yoff]

A new library was recently introduced. As much as possible of that should be made private.

[aschackmull]

Much more can be made private.

[yoff]

Much more can be made private.

Do you mean in other files or in the new file? I felt I could not hide previously exposed stuff in the javascript codebase, and I want the python files to be identical.

[yoff]

Ah, I guess I could make most classes private also..

[yoff]

Oh, and I missed all the typed predicates 🤦

[RasmusWL]

👍 from the Python side

[esbena]

A new library was recently introduced.

The library is less new for JavaScript (~4-6 months?). Is this privatization a breaking change for JavaScript? Or did we already cross that bridge when the shared RegExp libraries for Python/JavaScript were introduced?

[aschackmull]

Is this privatization a breaking change for JavaScript

I believe this code was recently hidden in a .ql file, so therefore implicitly private. But I haven't checked the details - I'm just drive-by commenting.

[yoff]

Is this privatization a breaking change for JavaScript

I believe this code was recently hidden in a .ql file, so therefore implicitly private. But I haven't checked the details - I'm just drive-by commenting.

That is correct, it was inside ReDoS.ql which has to import javascript. It defines the relevant ReDoSConfiguration and was pulled out so that the files can be identical.

[esbena]

In that case: 👍 from JS