Update logging information based on 'extractor-python.md'#626
Conversation
taus-semmle
left a comment
taus-semmle
left a comment
There was a problem hiding this comment.
One minor comment, otherwise looks good to me.
| * The `--verbose` flag can be specified specified multiple times to increase the logging level once per flag added. | ||
| * The `--quiet` flag can be specified multiple times to reduce the logging level once per flag added. | ||
| * Log lines are now in the `[SEVERITY] message` style and never overlap. | ||
| * The extractor now outputs the location of the first character that triggers an EncodingError. |
There was a problem hiding this comment.
This should be in a different section. It does not influence the output in the log, but rather improves the placement of the alert relating to an EncodingError. Previously, the alert was always displayed at the top of the file. With the extractor improvement, it'll now get displayed at the position of the character that caused the EncodingError.
There was a problem hiding this comment.
Thanks. I'll update accordingly here and in the related LGTM PR.
There was a problem hiding this comment.
Which query reports alerts for encoding errors? I want to check if it's run on LGTM or not.
There was a problem hiding this comment.
py/encoding-error: https://lgtm.com/rules/1814222703/
2 participants
This PR updates the information on logging based on the near duplicate content of
extractor-python.md.@taus-semmle - as discussed, I'll also raise a PR to delete the other file. I wasn't entirely sure whether the final bullet point about
EncodingErrorwas part of the logging improvements or not.