Skip to content

JavaScript: Teach Xss query about WinJS HTML injection functions.#628

Merged
semmle-qlci merged 1 commit into
github:masterfrom
xiemaisi:js/setUnsafeHTML
Dec 6, 2018
Merged

JavaScript: Teach Xss query about WinJS HTML injection functions.#628
semmle-qlci merged 1 commit into
github:masterfrom
xiemaisi:js/setUnsafeHTML

Conversation

@xiemaisi

@xiemaisi xiemaisi commented Dec 6, 2018

Copy link
Copy Markdown

No description provided.

@xiemaisi xiemaisi requested a review from a team as a code owner December 6, 2018 09:16
@xiemaisi

xiemaisi commented Dec 6, 2018

Copy link
Copy Markdown
Author

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I agree that the setOuterHTMLUnsafe name is distinct enough that we do not need to resolve it from WinJS.utilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants