Skip to content

JS: add persistent storage taint steps #629

Merged
xiemaisi merged 5 commits into
masterfrom
unknown repository
Dec 13, 2018
Merged

JS: add persistent storage taint steps #629
xiemaisi merged 5 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Dec 6, 2018

Copy link
Copy Markdown

This adds a simple, extensible flow step between writes and reads to persistent storage. The step is instantiated with cookie and webstorage models.

Potential extensions:

  • extend this to include steps for database accesses and JSON web tokens
  • allow flow between writes and reads for mixed cookie libraries
  • model server-side cookie libraries

Performance and results are unchanged.

@ghost ghost added the JS label Dec 6, 2018
@ghost ghost self-requested a review as a code owner December 6, 2018 09:52

@xiemaisi xiemaisi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor nits.

Comment thread javascript/ql/src/semmle/javascript/Concepts.qll Outdated
Comment thread javascript/ql/src/semmle/javascript/dataflow/TaintTracking.qll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant