Skip to content

JavaScript: Teach Unused{Variable,Parameter} to ignore variables with leading underscore.#656

Merged
semmle-qlci merged 1 commit into
github:masterfrom
xiemaisi:js/unused-local-underscore
Dec 12, 2018
Merged

JavaScript: Teach Unused{Variable,Parameter} to ignore variables with leading underscore.#656
semmle-qlci merged 1 commit into
github:masterfrom
xiemaisi:js/unused-local-underscore

Conversation

@xiemaisi

Copy link
Copy Markdown

Fixes #655.

@xiemaisi xiemaisi added the JS label Dec 11, 2018
@xiemaisi xiemaisi requested a review from a team as a code owner December 11, 2018 08:53

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Interestingly, the destructuring pattern with _ will hide the lodash library if it is in scope :).

@xiemaisi

Copy link
Copy Markdown
Author

Heh, indeed it will.

@semmle-qlci semmle-qlci merged commit 06dd5f3 into github:master Dec 12, 2018
@xiemaisi xiemaisi deleted the js/unused-local-underscore branch January 1, 2019 09:17
cklin pushed a commit that referenced this pull request May 23, 2022
Release preparation for version 2.7.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants