CPP: Small change to 'Resource not released in destructor'#809
Merged
Conversation
jbj
reviewed
Jan 21, 2019
| releaseExpr.getEnclosingFunction().getEnclosingAccessHolder*() = acquire.getEnclosingFunction() | ||
| // here, `getEnclosingAccessHolder*` allows us to go from a nested function or lambda | ||
| // expression to the class method enclosing it. | ||
| releaseExpr.getEnclosingElement*() = acquire.getEnclosingFunction() |
Contributor
There was a problem hiding this comment.
One detail: this * can be a +. It's probably insignificant here, but I've been bitten by this before -- see 11e03b3.
jbj
approved these changes
Jan 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change discussed in #672 (comment). @jbj is right, performance is if anything slightly better (not worse) with
getEnclosingElement, given a warmed up cache.