Skip to content
This repository was archived by the owner on Jun 17, 2026. It is now read-only.

Merge reference implementation SDK changes (2026-05-17)#210

Closed
Copilot wants to merge 5 commits into
mainfrom
copilot/reference-impl-sync-9-new-commits-again
Closed

Merge reference implementation SDK changes (2026-05-17)#210
Copilot wants to merge 5 commits into
mainfrom
copilot/reference-impl-sync-9-new-commits-again

Conversation

Copilot AI commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ports 9 commits from github/copilot-sdk (e20f5bef→25b15be8).

Before the change?

  • CustomAgentConfig had no way to specify a preferred model for an agent
  • Permission-reject E2E test only verified the file wasn't modified, not that the CLI surfaced the correct "user rejected" error discriminator (copilot-sdk#1194)
  • @github/copilot pinned at previous version

After the change?

  • CustomAgentConfig.setModel(String) — optional model identifier (e.g. "claude-haiku-4.5"); runtime falls back to parent session model if unavailable
  • testDenyPermission now asserts a ToolExecutionCompleteEvent with "user rejected" error, matching the hardened .NET test
  • @github/copilot synced to ^1.0.49-1, .lastmerge updated

Not ported (intentionally)

Commit Reason
25b15be .NET MSBuild targets Not applicable to Java/Maven
31ea472 / 59f0981 Python doc fixes Python-only
bc0f1c4 ask_user snapshot consolidation Java SDK already uses canonical ask_user folder
fc11032 Compaction E2E stabilization Test harness (Node.js) only
Session.cs reasoningSummary param Requires codegen regeneration from updated @github/copilot types

Example

var agent = new CustomAgentConfig()
    .setName("code-reviewer")
    .setModel("claude-haiku-4.5")
    .setPrompt("You are a code review expert.");

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • mvn spotless:apply has been run to format the code
  • mvn clean verify passes locally

Does this introduce a breaking change?

  • Yes
  • No

Copilot AI linked an issue May 17, 2026 that may be closed by this pull request
[reference-impl-sync] Reference Implementation sync: 9 new commits (2026-05-17) #209
Closed
Copilot AI and others added 2 commits May 17, 2026 16:38
@edburns
Port model field for CustomAgentConfig from reference implementation
f6b5eef 
Adds a 'model' field to CustomAgentConfig allowing agents to specify
a preferred model (e.g., 'claude-haiku-4.5'). When set, the runtime will
attempt to use this model for the agent, falling back to the parent
session model if unavailable.

Reference: d0eb531 feat: add model field to CustomAgentConfig across all SDKs (#1309)

Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
@edburns
Update .lastmerge to 25b15be86c443c776bc2ab057c698a2ef0b67f35, sync p…
3f3ceb6 
…om.xml CLI version, and update scripts/codegen @github/copilot version

Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Copilot AI changed the title [WIP] Sync reference implementation with 9 new commits Merge reference implementation SDK changes (2026-05-17) May 17, 2026
Copilot AI requested a review from edburns May 17, 2026 17:06
@github-actions
Regenerate codegen output
e770707 
Auto-committed by codegen-check workflow.
@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label May 18, 2026
@github-actions
Fix build failures after @github/copilot update
f560af8 
SessionModelSwitchToParams record gained a new reasoningSummary field,
requiring callers to pass 5 arguments instead of 4. Updated both call
sites in CopilotSession to pass null for the new reasoningSummary
parameter.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Commit pushed: f560af8

Generated by Codegen Agentic Fix

@edburns

edburns commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #212 .

@edburns edburns closed this May 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@edburns edburns Awaiting requested review from edburns

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@edburns edburns

Copilot code review Copilot

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[reference-impl-sync] Reference Implementation sync: 9 new commits (2026-05-17)

2 participants

@edburns