Skip to content

sync reports success (exit 0) when its internal push fails #472

Description

@norswap

(This issue was AI generated but I have read it, understood it, and I'm accountable for its content.)

Version: gh-stack v0.1.0.

Repro: a stack whose branches are already pushed; rebase the stack locally (tips now require a force-push); run gh stack sync.

Actual output:

Pushing 3 branches to origin...
⚠ Push failed — branches may need force push after rebase
  Run `gh stack push` to push with --force-with-lease.
...
✓ Stack synced

with exit code 0, while the branches were not pushed.

Expected: either sync pushes with --force-with-lease --atomic as its own documentation describes (step 5 of the sync help text), or the run exits non-zero when the push step fails. A warning followed by a success line and a zero exit makes sync unusable in scripts and easy to misread interactively.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions