Skip to content

checkout: dynamic height for picker - #469

Open
skarim wants to merge 1 commit into
mainfrom
skarim/checkout-tui-height
Open

checkout: dynamic height for picker#469
skarim wants to merge 1 commit into
mainfrom
skarim/checkout-tui-height

Conversation

@skarim

@skarim skarim commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Updates the checkout picker to use the available terminal height when more than 10 stacks are available, instead of always capping the list at 10 rows.

The picker still stays compact for smaller result sets and preserves the existing spacing for search controls and inline rendering.


Stack created with GitHub Stacks CLIGive Feedback 💬

Copilot AI balanced review requested due to automatic review settings August 24, 2026 20:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the inline checkout picker to use available terminal height while remaining compact for smaller lists.

Changes:

  • Dynamically sizes visible stack rows based on terminal height.
  • Adds coverage for fallback, compact, expanded, search, and constrained layouts.
Show a summary per file
File Description
internal/tui/checkoutview/model.go Implements dynamic picker height calculation.
internal/tui/checkoutview/model_test.go Tests dynamic sizing and rendered height.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Base automatically changed from skarim/vim-keybindings to main August 24, 2026 20:29
@skarim skarim changed the title dynamic height for checkout picker checkout: dynamic height for picker Aug 24, 2026
@skarim skarim self-assigned this Aug 24, 2026
@skarim
skarim force-pushed the skarim/checkout-tui-height branch from 66f9123 to 7688a13 Compare August 25, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants