fix(bundler): pass explicit option values when delegating to workflow_add

[jawwad-ali]

Problem

specify bundle install can never install a workflow component. It fails 100% of the time, with an error about --dev that has nothing to do with what the user asked for.

bundler/services/primitives.py delegates to the Typer command callables in-process, as its module docstring describes:

lambda: workflow_add(component.id)

But workflow_add declares two typer.Option parameters (workflows/_commands.py:1712-1716):

def workflow_add(
    source: str = typer.Argument(..., help="Workflow ID, URL, or local path"),
    dev: bool = typer.Option(False, "--dev", ...),
    from_url: str | None = typer.Option(None, "--from", ...),
):

Called from Python rather than through Typer, an omitted option parameter keeps its OptionInfo sentinel as the value:

dev default      -> OptionInfo   truthy=True
from_url default -> OptionInfo   is None=False

So if dev: is always true and the function takes the local-path branch.

Reproduction on current main (bf88c9f)

>>> primitive_manager("workflows", project, allow_network=True).install(
...     ComponentRef(kind="workflows", id="code-review", version="1.0.0"))

Error: --dev source must be a workflow YAML file, supported archive, or
directory containing workflow.yml: code-review

BundlerError: Failed to install workflow 'code-review'.

The catalog install path is unreachable.

Why only this call site

A signature survey of all four delegated callables:

callable	parameters
workflow_add	source=ArgumentInfo, dev=OptionInfo, from_url=OptionInfo
workflow_remove	workflow_id=ArgumentInfo
workflow_step_add	step_id=ArgumentInfo
workflow_step_remove	step_id=ArgumentInfo

workflow_add is the only one that declares options, and it is the only call site that omits them — so the other three are safe exactly as written, and this fix is correctly scoped to one line.

Fix

lambda: workflow_add(component.id, dev=False, from_url=None),

No breaking change. No input that works today behaves differently — today every bundler workflow install fails; afterwards it reaches the catalog path the code always intended.

Verification

• Fail-before / pass-after: the new test fails on unpatched src and passes with the fix — 1 failed → 21 passed.
• The new test asserts the values, not just the call: dev is False and from_url is None, so a future regression to sentinels is caught rather than silently swallowed by a **kwargs stub.
• One existing stub (lambda wid: ...) had to accept the kwargs; I made it capture them instead of discarding them.
• Scoped regression over tests/unit: no new failures vs a clean-main baseline captured on bf88c9f9.
• uvx ruff@0.15.0 check src tests → clean

---

Written with assistance from Claude Code. Bug found, reproduced, and verified by me on current main.

[Copilot]

Pull request overview

Fixes workflow bundle installation by supplying concrete Typer option values during in-process delegation.

Changes:

• Passes dev=False and from_url=None to workflow_add.
• Adds regression coverage verifying both values.

Show a summary per file

File	Description
src/specify_cli/bundler/services/primitives.py	Corrects workflow installation delegation.
tests/unit/test_bundler_primitives.py	Adds and updates delegation tests.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

[jawwad-ali]

Rebased onto current main — the conflict is resolved and this is MERGEABLE again.

In fairness, you should know this is now largely superseded. While it sat, #4284 (041faee, merged Sep 1) landed the identical source fix:

lambda: workflow_add(component.id, dev=False, from_url=None),

and folded the same regression assertion into the existing test:

assert calls == [("bundled-wf", False, None)]

That is exactly why this branch conflicted — main had already grown my change by another route.

Resolving the conflict, I took main's side wherever it was equal or better: its test_offline_workflow_allows_bundled captures (wid, dev, from_url) as a tuple, which is a stronger assertion than my original **kwargs-swallowing version, so I dropped mine in favour of it.

What remains unique here is small and entirely additive:

1. An explanatory comment at the call site recording why the explicit values are required — that outside Typer an omitted typer.Option keeps its OptionInfo sentinel, which is truthy and not None, so workflow_add's if dev: took the local-path branch for every catalog install. It also notes that workflow_add is the only one of the four delegated commands declaring options; workflow_remove / workflow_step_add / workflow_step_remove take a bare typer.Argument and are safe as written.
2. test_workflow_install_passes_explicit_typer_options, a dedicated test naming the sentinel trap. Its coverage overlaps what fix(bundler): pass explicit workflow_add options from bundle install #4284 already asserts, so it is a documentation-grade duplicate rather than new protection.

Entirely your call whether that is worth carrying — I'm happy to close this if you would rather not review a near-duplicate, and I won't be offended either way. Verified after the rebase: 26 passed in tests/unit/test_bundler_primitives.py, uvx ruff@0.15.0 check src tests clean.