fix(extensions): reject non-mapping extension.yml config section

[Noor-ul-ain001]

Summary

• ConfigManager._get_extension_defaults() read an extension's extension.yml config.defaults via manifest_data.get("config", {}).get("defaults", {}) with no shape check on the intermediate config value. Shipped extensions (e.g. extensions/git/extension.yml) use a top-level config: { defaults: {...} } section — distinct from the already-validated provides.config list. A manifest with config: [] or config: "oops" made the chained .get() raise a bare AttributeError instead of degrading gracefully like every other malformed config source in this class.
• That crash was silently swallowed by should_execute_hook's blanket except Exception, so a hook's config.x is set condition permanently evaluated to False for the extension with no diagnostic — a hook that should run (or should raise a clear error) instead silently never fires.
• Mirrors the existing TestConfigManagerNonMappingYaml coverage for a non-mapping root of <id>-config.yml (already fixed), one level deeper in the manifest's own config section, which was previously unchecked. ExtensionManifest._validate() does not validate this top-level config field at all.

Test plan

• Added TestConfigManagerNonMappingManifestConfigSection to tests/test_extensions.py (5 tests: list config:, scalar config:, non-mapping config.defaults, valid-shape regression guard, and a HookExecutor._evaluate_condition non-crash check)
• Verified all 4 crash-reproducing tests fail without the fix (AttributeError: 'list'/'str' object has no attribute 'get') and pass with it — stashed only the source change (src/specify_cli/extensions/__init__.py), confirmed the failure, then restored it and confirmed the pass
• Ran tests/test_extensions.py full suite — 505 passed, 20 pre-existing failures (Windows symlink-elevation and env-specific; reproduced identically on the unmodified branch), 8 skipped — no regressions

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01FW9fAYsCBCAgdKWovtSyqt

[Copilot]

🟢 Approval recommended

The focused defensive fix is correct and comprehensively tested.

Pull request overview

Prevents malformed extension manifest configuration from crashing config and hook resolution.

Changes:

• Safely ignores non-mapping config and config.defaults values.
• Adds regression coverage for malformed and valid manifest configurations.

File summaries

File	Description
src/specify_cli/extensions/__init__.py	Validates manifest configuration shapes before reading defaults.
tests/test_extensions.py	Tests malformed configuration and hook evaluation behavior.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[mnriem]

Please fix test & lint errors

[Noor-ul-ain001]

@mnriem I looked into the CI failure on the last run before pushing anything.

• ruff passed on that run — there were no lint errors.
• The only real failure was pytest (windows-latest, 3.13): a subprocess.TimeoutExpired in tests/extensions/test_extension_agent_context.py::TestBundledUpdaterPathValidation::test_powershell_script_discovers_nested_plan (job log). That test never touches extension config resolution — it's unrelated to this PR's diff.
• The two macOS pytest jobs show cancelled, not failure (matrix fail-fast after the Windows job failed).
• I confirmed this same Windows timeout also fails on main itself, on an unrelated commit: run from 2026-09-11. So it's pre-existing CI flakiness in the PowerShell subprocess test, not something introduced here.

The branch was also 87 commits behind main, so I rebased it onto current main (clean, no conflicts) and re-verified locally: ruff check . passes, and the full tests/test_extensions.py suite passes (the only 2 local failures are TestExtensionConfigScaffolding symlink tests that need Windows admin elevation to create symlinks — an environmental gap on my machine, not a code issue). Pushed the rebase; let's see what CI reports now.