Skip to content

fix(extensions): normalize literal command calls in generated skills - #4521

Open
MahinurRahman wants to merge 1 commit into
github:mainfrom
MahinurRahman:fix/3451-extension-command-references
Open

fix(extensions): normalize literal command calls in generated skills#4521
MahinurRahman wants to merge 1 commit into
github:mainfrom
MahinurRahman:fix/3451-extension-command-references

Conversation

@MahinurRahman

Copy link
Copy Markdown

Summary

Fixes #3451.

Extension commands can contain literal cross-command calls such as /speckit.memory-md.prepare-context. When those commands are installed as skills, the generated SKILL.md previously retained the dotted slash form even for integrations that require hyphenated skill names or a different invocation prefix.

This change normalizes literal skill invocations in the shared skill renderer and extension-manager skill registration path. It supports Codex ($speckit-*), Claude/Copilot (/speckit-*), and Kimi (/skill:speckit-*). Canonical command IDs, file paths, URLs, and ordinary non-skill command layouts are preserved.

New regression coverage exercises four integrations through both skill registration paths, verifies idempotence and path/URL preservation, and confirms ordinary command output remains dotted.

Testing

  • Focused regression: 9 passed.
  • Broader extension/preset/placeholder run: 1,201 passed, 3 skipped, 23 deselected. Symlink-named tests were excluded because this Windows account cannot create symbolic links (WinError 1314); the failures were test setup failures, not assertion failures.
  • CLI smoke test: initialized a non-interactive Codex skills project with the PowerShell environment and installed a local two-command extension. The generated skill invoked $speckit-invocation-smoke-finish and the referenced skill existed.
  • git diff --check passed.

AI disclosure: Codex authored the implementation, tests, documentation, and validation on behalf of MahinurRahman. The work was performed autonomously; no human line-by-line review or external-agent execution is claimed.

@mnriem mnriem added the triage-nice-to-have Verdict: evidence-backed fix or greenlit feature — land after review label Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage-nice-to-have Verdict: evidence-backed fix or greenlit feature — land after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Extension command references not rewritten for skills-based integrations (Codex), breaking cross-command invocation

2 participants