Skip to content

Devops 384 action upgrade#37

Merged
githubofkrishnadhas merged 4 commits into
mainfrom
DEVOPS-384-action-upgrade
Jun 1, 2026
Merged

Devops 384 action upgrade#37
githubofkrishnadhas merged 4 commits into
mainfrom
DEVOPS-384-action-upgrade

Conversation

@githubofkrishnadhas
Copy link
Copy Markdown
Owner

@githubofkrishnadhas githubofkrishnadhas commented Jun 1, 2026

Summary:

  • Upgrade the action container to python:3.13-slim-bullseye.
  • Ensure entrypoint.sh is executable and install runtime dependency uv.
  • Add uv to the container PATH and set the container entrypoint to entrypoint.sh.

Key changes:

Updated Dockerfile to:

  • Use FROM python:3.13-slim-bullseye

Why:

  • Move to Python 3.13 for parity with environment requirements.
  • Ensure the action's entrypoint is executable and required Python dependency uv is installed and available on PATH.

Summary by CodeRabbit

  • Chores
    • Upgraded Python runtime from version 3.11 to 3.13.
    • Updated build and deployment infrastructure.
    • Reorganized dependency management configuration.

@githubofkrishnadhas githubofkrishnadhas self-assigned this Jun 1, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e735704b-61e1-4bb0-8f93-c97413eb928b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
Dockerfile (1)

9-9: ⚡ Quick win

Drop the dangling apt-get update.

Nothing is installed via apt in this layer, so apt-get update -y only refreshes package lists (leaving cache behind) without ever being followed by an apt-get install — this is exactly what Trivy DS-0017 flags. Remove it, and pin uv for reproducible builds.

♻️ Proposed change
-# Install uv
-RUN chmod +x entrypoint.sh &&  apt-get update -y && pip install uv
+# Install uv
+RUN chmod +x entrypoint.sh && pip install --no-cache-dir uv==<pin-version>
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` at line 9, Remove the dangling apt-get update from the RUN line
and pin the pip package to a specific version for reproducible builds: keep the
chmod +x entrypoint.sh, drop "apt-get update -y", and change "pip install uv" to
a version-pinned install like "pip install uv==<desired-version>" (use an
explicit version) so the final RUN contains only the chmod and the pinned pip
install.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@entrypoint.sh`:
- Around line 3-4: Update the stale comment to remove the pipenv reference and
fix the typo (replace "installng pipenv and creating pipenv venv" with a brief
accurate comment about syncing and listing the app), and add failure handling by
enabling strict exit-on-error (e.g., add set -e near the top) so a failing uv
sync stops the script; ensure the commands referenced are the existing uv sync
and uv tree invocations so they fail fast instead of continuing to the JWT
command.

---

Nitpick comments:
In `@Dockerfile`:
- Line 9: Remove the dangling apt-get update from the RUN line and pin the pip
package to a specific version for reproducible builds: keep the chmod +x
entrypoint.sh, drop "apt-get update -y", and change "pip install uv" to a
version-pinned install like "pip install uv==<desired-version>" (use an explicit
version) so the final RUN contains only the chmod and the pinned pip install.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 59b6a384-130c-4902-b337-aac3f7354b4a

📥 Commits

Reviewing files that changed from the base of the PR and between b15b511 and e90fdc4.

⛔ Files ignored due to path filters (2)
  • Pipfile.lock is excluded by !**/*.lock
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • Dockerfile
  • Makefile
  • Pipfile
  • entrypoint.sh
  • pyproject.toml
💤 Files with no reviewable changes (1)
  • Pipfile

Comment thread entrypoint.sh
@githubofkrishnadhas githubofkrishnadhas merged commit 752e1a6 into main Jun 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant