v1.3.0 Prep

[housseindjirdeh]

Next release: v1.3.0 - Monday October 2nd

Let's use this ticket to list all the some details we'll need to fix/update before our next release.

EXCITED TO GET A NEW RELEASE OUT!

[housseindjirdeh]

After our release, we'll spend some significant amount of time improving a number of things in the app:

• Streamlining release flow and CI using Fastlane and Buddybuild or bitrise
• Rearchitecting our state to leverage normalizer (progress began here Experimenting with normalizr #350)
• Moving over to GraphQL incrementally (progress began here refactor(orgs): get organizations via GraphQL and display name instead login #347)
• Lay out a more concrete UI guideline flow (similar to how buttons are being mapped here feat(ux): introduce our standardized <Button /> #374)
• Keep adding more features! For me the real big wins are things like Enteprise support as well showing pull request review comments for example. But there's still a ton of amazing things left to add

All the above is for future discussion, but just wanted to put that here in case people where were wondering what's next :)

[machour]

• Implement a solid and verbose v3client implementing all high level api calls (v3.user.getOrgs(), etc.) and use only the high level api in *.actions.js. No more direct calls to v3.get() and other low level methods.

• oupsy *

[andrewda]

Super excited for this!!

Side note, can we be sure to use the semver terms for releases (v1.3.0) just in case we have to release a patch?

[housseindjirdeh]

Yep that's a good point, will make sure to use semver from now on 🙌

[housseindjirdeh]

@lex111 Just noticed two minor things:

• The 99+ icon doesn't show perfectly for iPhone:

• When Mark all Notifications is tapped, it doesn't refresh the pending and all notifications screens:

• Think we can update the Mark All Notifications Button as green maybe to match the merge button?

Please don't feel like you have to get to this right now. Just putting it here so we can address it before our release on Monday :) (more than happy to take care of it myself)

[lex111]

When Mark all Notifications is tapped, it doesn't refresh the pending and all notifications screens:

This I fixed in #371, but need to check so.

The 99+ icon doesn't show perfectly for iPhone:

Ooops, I'll fix it, admit I did not look at iOS :(

By the way, will we change the fonts so that they have the same everywhere?

Think we can update the Mark All Notifications Button as green maybe to match the merge button?

#371 is not yet merged, so it's better to write it down there :)

[housseindjirdeh]

This I fixed in #371, but need to check so.

Seems to be what's happening on #371 unfortunately. No worries it isn't anything major breaking. I'll merge it in and we'll triage it in master.

Ooops, I'll fix it, admit I did not look at iOS :(

By the way, will we change the fonts so that they have the same everywhere?

Yep exactly so that's why I don't want you to stress over it, I'm going to be applying UI updates with the font change anyway

#371 is not yet merged, so it's better to write it down there :)

Yep was thinking the same thing :)

[lex111]

@housseindjirdeh Ok, for the weekend I think we'll do it, but the font you can do?

[housseindjirdeh]

@lex111 Yep I can take care of that :) If not today then tomorrow!

[machour]

⚠️ we need to merge gitpoint/git-point-site#10 and change the host in MarkdownWebView before the release.

[jouderianjr]

hey everyone, I was talking with @machour on gitter about #327 as he said, some user normally keeps his finger on the screen while scrolls the app. In issue screen, we added the long press event and for these users, this long press event could be very annoying.

Personally, I have this exact problem when I use facebook app :/

What do you think about to remove it?

[Antoine38660]

Font on events screen seems too bold on iPhone (only seeing this issue myself, @machour can't reproduce it which is interesting 🤔)

I can't reproduce it too 🤔 Descriptions (grey parts) doesn't look bold at all

Something that I've been thinking, update fonts in app to Nunito

I can try to add Nunito instead of AvenirNext and OpenSans and give you some screenshots !

Excited by this new release 😍 🎉

[housseindjirdeh]

@machour Noted!

@jouderianjr yep personally very okay with removing the long press entirely :)

@Antoine38660 Interesting i have no idea why it's just me lol 🤔 Would love it if you can help out adding Nunito :) Please let me know as soon as you can how it goes!